post-rank-handler #143
Merged
post-rank-handler #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💩 Code linting failed, use |
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Zimovchik
requested changes
Aug 24, 2025
Member
There was a problem hiding this comment.
Если ты не будешь каждый раз чистить табличку и заполнять ее заново, это позволит обеспечить консистентность. У тебя не будет ни единого момента, когда кто-то из лекторов будет без оценки, потому что может ты базу очистишь, а потом все ляжет и заново она не дозаполнится
а чтобы решить проблему первого заполнения, можно сделать nullable=False, default= 0, например
Member
|
соответственно
|
|
💩 Code linting failed, use |
added 2 commits
August 30, 2025 22:11
Zimovchik
approved these changes
Sep 4, 2025
| rank: Mapped[int] = mapped_column( | ||
| Integer, nullable=False, server_default='0', default=0, comment="Место в рейтинге, посчитана в dwh" | ||
| ) | ||
| rank_update_ts: Mapped[datetime.datetime] = mapped_column( |
Member
There was a problem hiding this comment.
респект, правильно, что добавил
rating_api/routes/lecturer.py
Outdated
Comment on lines
206
to
209
| async def delete_lecturer( | ||
| id: int, _=Depends(UnionAuth(scopes=["rating.lecturer.delete"], allow_none=False, auto_error=True)) | ||
| ): | ||
| async def delete_lecturer(id: int, allow_none=False, auto_error=True): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Добавил ручку, которая кладет данные рейтинга препода в бд
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?